Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build][ROCm] Enabling LoRA tests on ROCm #7369

Merged
merged 32 commits into from
Sep 4, 2024
Merged

[CI/Build][ROCm] Enabling LoRA tests on ROCm #7369

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
31655b7
Modifying test_quant_model.py, AWQ is not supported on ROCm
alexeykondrat Aug 9, 2024
26d8429
xfailing Gemma test for further investigation
alexeykondrat Aug 9, 2024
670e3c6
Enabling LoRA tests for AMD in Buildkite
alexeykondrat Aug 9, 2024
a58f019
Adding reason for Gemma test xfail
alexeykondrat Aug 9, 2024
39f9bec
Fixing MODELS re-definition
alexeykondrat Aug 9, 2024
d8207ed
Removing - csrc/punica for LoRA dependancies
alexeykondrat Aug 12, 2024
df0efb1
Sorting imports
alexeykondrat Aug 14, 2024
a4f78e5
Update alignment
alexeykondrat Aug 14, 2024
91ce9c4
Make yapf happy
alexeykondrat Aug 14, 2024
32f3a10
Update test_quant_model.py
alexeykondrat Aug 14, 2024
a103778
Update test_quant_model.py
alexeykondrat Aug 14, 2024
1d35abb
Make yapf(3.11) happy
alexeykondrat Aug 14, 2024
1d1a86c
Removing csrc/punica dependency for LoRA long context test test-pipe…
alexeykondrat Aug 14, 2024
85f76e9
Exposing single GPU to the container
alexeykondrat Aug 14, 2024
23017cc
Passing Bildkite env vars to container for pytest
alexeykondrat Aug 14, 2024
d7cde25
Explicitly setting number of parallel jobs(shards in pytest) to 1
alexeykondrat Aug 15, 2024
f7794a6
Removing unused arguments in test shell script
alexeykondrat Aug 16, 2024
d371265
Placing the quotes around the test commands
alexeykondrat Aug 16, 2024
f853c58
Remove single quotes
alexeykondrat Aug 16, 2024
fa9f388
Automatically replacing CUDA_VISIBLE_DEVICES with HIP_VISIBLE_DEVICE…
alexeykondrat Aug 16, 2024
64f12e4
trying to run four instances in parallel
alexeykondrat Aug 17, 2024
dfb0e4c
adding GPU number to container name
alexeykondrat Aug 17, 2024
27f6e00
Re-enabling LoRA tests
alexeykondrat Aug 17, 2024
bbe7696
Running four docker processes in parallel
alexeykondrat Aug 19, 2024
46682e3
Using pipefail option to propagate the error code
alexeykondrat Aug 19, 2024
b3fc101
Run 8 parallel jobs
alexeykondrat Aug 19, 2024
dd12ded
Fixing pipe operator
alexeykondrat Aug 19, 2024
6c43c65
Removing comment
alexeykondrat Aug 19, 2024
5c6cdc3
Merge remote-tracking branch 'upstream/main' into lora_test_enablement
alexeykondrat Aug 23, 2024
c48c569
Resolving conflict in run-amd-test.sh and merging with main
alexeykondrat Aug 28, 2024
16ea3cf
Update comment in .buildkite/run-amd-test.sh
alexeykondrat Sep 3, 2024
1de52bd
Removed commented out string run-amd-test.sh
alexeykondrat Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enabling LoRA tests for AMD in Buildkite
  • Loading branch information
@alexeykondrat
alexeykondrat committed Aug 22, 2024
commit 670e3c65ac94d744ffa7e6bfcd5bd68cb794d4cb
1 change: 1 addition & 0 deletions .buildkite/test-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ steps:
- pytest -v -s spec_decode

- label: LoRA Test %N # 30min each
mirror_hardwares: [amd]
source_file_dependencies:
- vllm/lora
- csrc/punica
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- csrc/punica is unused，could you please delete it, thank you

Copy link
Contributor

@jeejeelee jeejeelee Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, line 314 should also be deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Expand Down