Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Make building wheels per commit optional #7278

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Aug 7, 2024

  • We don't need per commit wheels all the time. If anyone needs a commit wheel, unblocking it takes like 8-10 mins for CUDA 12.1 wheel to be built.

p
Signed-off-by: kevin <kevin@anyscale.com>
@khluu khluu requested a review from simon-mo August 7, 2024 18:17
Copy link

github-actions bot commented Aug 7, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 7, 2024
@khluu
Copy link
Collaborator Author

khluu commented Aug 7, 2024

Test build shows building wheel is blocked now: https://buildkite.com/vllm/release/builds/613

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually documented per commit wheel. Can we just always run 12.1 but not build 11

khluu added 2 commits August 7, 2024 18:23
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
@khluu
Copy link
Collaborator Author

khluu commented Aug 7, 2024

We actually documented per commit wheel. Can we just always run 12.1 but not build 11

done. 11.8 is optional to build now

@khluu khluu requested a review from simon-mo August 7, 2024 18:26
p
Signed-off-by: kevin <kevin@anyscale.com>
@simon-mo simon-mo merged commit 469b3bc into vllm-project:main Aug 7, 2024
19 of 23 checks passed
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants