Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented Aug 5, 2024

See https://stackoverflow.com/a/8958414

Should address issues #7138, #7118.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job finding the reference for this, makes sense!

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stackoverflow reference is great!

@youkaichao
Copy link
Member

It looks strange to me, why @robertgshaw2-neuralmagic does not met this when he test the functionality. Is it ZMQ version specific?

@youkaichao youkaichao merged commit 003f8ee into vllm-project:main Aug 5, 2024
@njhill njhill deleted the zmq-bind-localhost branch August 5, 2024 15:42
@njhill
Copy link
Member Author

njhill commented Aug 5, 2024

It looks strange to me, why @robertgshaw2-neuralmagic does not met this when he test the functionality. Is it ZMQ version specific?

I had the same thought

@robertgshaw2-redhat
Copy link
Collaborator

I am also confused why this issue does not arise in automation or locally

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants