Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][misc] simply output processing with shortcut for non-parallel sampling and non-beam search usecase #7117

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

youkaichao
Copy link
Member

No description provided.

@youkaichao
Copy link
Member Author

it is a tiny step of #7116

Copy link

github-actions bot commented Aug 4, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member Author

On H100:

python benchmarks/benchmark_throughput.py --input-len 256 --output-len 256 --model meta-llama/Meta-Llama-3-8B

Main branch (3 trials):

Throughput: 24.32 requests/s, 12453.04 tokens/s
Throughput: 24.11 requests/s, 12342.76 tokens/s
Throughput: 24.29 requests/s, 12434.40 tokens/s

This PR (3 trials):

Throughput: 24.52 requests/s, 12555.73 tokens/s
Throughput: 24.59 requests/s, 12591.35 tokens/s
Throughput: 24.74 requests/s, 12667.68 tokens/s

Already 1.5% improvement in throughput.

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youkaichao youkaichao merged commit 83c644f into vllm-project:main Aug 4, 2024
31 checks passed
@youkaichao youkaichao deleted the simplify_output_process branch August 4, 2024 07:22
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants