Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] bump Dockerfile.neuron image base, use public ECR #6832

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Jul 26, 2024

The current Neuron base image fails to build in CI due to a malformed requirements string.

It also seems that the current image is not public. I switched over to the image provided in https://github.com/aws-neuron/deep-learning-containers?tab=readme-ov-file#pytorch-inference-neuronx

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@njhill
Copy link
Member

njhill commented Jul 26, 2024

@liangfu does this look ok to you?

@WoosukKwon
Copy link
Collaborator

@liangfu Could you please take a look?

@dtrifiro
Copy link
Contributor Author

dtrifiro commented Aug 6, 2024

@liangfu any chance this could get merged?

@dtrifiro
Copy link
Contributor Author

@njhill @WoosukKwon since CI is passing and the build does not actually work for neuron, how about merging this? This would also unblock #4738

Copy link
Contributor

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes looks good. thanks for the contribution, and sorry for the late reply.

@youkaichao youkaichao merged commit d2bc451 into vllm-project:main Aug 12, 2024
29 checks passed
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
@dtrifiro dtrifiro deleted the bump-neuron-base branch August 12, 2024 23:43
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants