-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] bump Dockerfile.neuron image base, use public ECR #6832
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
@liangfu does this look ok to you? |
@liangfu Could you please take a look? |
@liangfu any chance this could get merged? |
@njhill @WoosukKwon since CI is passing and the build does not actually work for neuron, how about merging this? This would also unblock #4738 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes looks good. thanks for the contribution, and sorry for the late reply.
…oject#6832) Signed-off-by: Alvant <alvasian@yandex.ru>
The current Neuron base image fails to build in CI due to a malformed requirements string.
It also seems that the current image is not public. I switched over to the image provided in https://github.com/aws-neuron/deep-learning-containers?tab=readme-ov-file#pytorch-inference-neuronx