Skip to content

[Frontend] Factor out code for running uvicorn #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 27, 2024
Merged

[Frontend] Factor out code for running uvicorn #6828

merged 3 commits into from
Jul 27, 2024

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 26, 2024 •
edited
Loading

Following #6740, this PR further factors out common code for running the server, unifying the code structure between the OpenAI server entrypoint and the legacy server entrypoint. It also introduces a new module vllm.server for server-related code, which may be used for #6797.

cc @dtrifiro

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 requested a review from simon-mo July 26, 2024 07:35
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 26, 2024
@DarkLight1337
Copy link
Member Author

@robertgshaw2-neuralmagic we can implement #6797 inside the new module vllm.server introduced by this PR.

simon-mo
simon-mo approved these changes Jul 27, 2024
View reviewed changes
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. as long this doesn't break scripts.py

@DarkLight1337 DarkLight1337 merged commit 981b0d5 into vllm-project:main Jul 27, 2024
@DarkLight1337 DarkLight1337 deleted the server-commons branch July 27, 2024 01:58
simon-mo added a commit that referenced this pull request Jul 31, 2024
@simon-mo
Revert "[Frontend] Factor out code for running uvicorn (#6828)"
8f09639 
This reverts commit 981b0d5.
@simon-mo simon-mo mentioned this pull request Jul 31, 2024
Merged
@DarkLight1337 DarkLight1337 mentioned this pull request Aug 3, 2024
Merged
@dtrifiro dtrifiro mentioned this pull request Aug 5, 2024
Closed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@DarkLight1337 @Alvant
[Frontend] Factor out code for running uvicorn (vllm-project#6828)
a4a6776 
Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@DarkLight1337 @LeiWang1999
[Frontend] Factor out code for running uvicorn (vllm-project#6828)
ee3c6dc 
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo simon-mo approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

+1 more reviewer

@dtrifiro dtrifiro dtrifiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DarkLight1337 @simon-mo @dtrifiro