Skip to content

[Bugfix] Fix awq_marlin and gptq_marlin flags #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2024
Merged

[Bugfix] Fix awq_marlin and gptq_marlin flags #6745

merged 2 commits into from
Jul 25, 2024

Conversation

@alexm-redhat
Copy link
Collaborator

This PR ensures that --quantization=gptq_marlin or --quantization=awq_marlin will use the marlin versions of the kernels.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-redhat
Copy link
Collaborator Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2024
@alexm-redhat alexm-redhat mentioned this pull request Jul 24, 2024
Merged
mgoin
mgoin approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I knew it was this easy, I would have asked for this sooner :) Thanks!

@alexm-redhat
Copy link
Collaborator Author

/ready

@mgoin mgoin enabled auto-merge (squash) July 24, 2024 18:48
@simon-mo simon-mo merged commit 0310029 into vllm-project:main Jul 25, 2024
@dtrifiro dtrifiro mentioned this pull request Aug 5, 2024
Closed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@alexm-redhat @Alvant
[Bugfix] Fix awq_marlin and gptq_marlin flags (vllm-project#6745)
bb21679 
Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@alexm-redhat @LeiWang1999
[Bugfix] Fix awq_marlin and gptq_marlin flags (vllm-project#6745)
337b3c7 
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexm-redhat @mgoin @simon-mo