Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx-argparse version #6453

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Jul 15, 2024

Pin to 0.4.0 due to 0.5.0 failing doc build on main: https://buildkite.com/vllm/ci-aws/builds/4946#0190b7c3-4ac2-41c4-9e11-c704a0830e08

p
Signed-off-by: kevin <kevin@anyscale.com>
@khluu khluu requested a review from simon-mo July 15, 2024 22:02
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger fastcheck CI to run, which consists only a small and essential subset of tests to quickly catch errors with the flexibility to run extra individual tests on top (you can do this by unblocking test steps in the Buildkite run).

Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well.

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac enabled auto-merge (squash) July 15, 2024 23:11
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 15, 2024
@comaniac comaniac merged commit d6f3b3d into vllm-project:main Jul 16, 2024
88 of 89 checks passed
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
Signed-off-by: kevin <kevin@anyscale.com>
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 19, 2024
Signed-off-by: kevin <kevin@anyscale.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants