Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add grouped tests & mark tests to run by default for fastcheck pipeline #6365

Merged
merged 21 commits into from
Jul 12, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Jul 12, 2024

  • Add grouped test for Async Engine, Inputs, Utils, Worker tests & Tensorizer, Metrics, Tracings tests
  • Mark Regression, Basic Correctness, Core, Distributed (4 GPU), and Entrypoints tests to run on fastcheck by default

Template for fastcheck pipeline is merged here: https://github.com/vllm-project/buildkite-ci/blob/main/scripts/test-template-fastcheck.j2

khluu added 17 commits July 1, 2024 23:17
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
P
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
@khluu khluu marked this pull request as ready for review July 12, 2024 06:26
@khluu khluu requested a review from simon-mo July 12, 2024 06:26
@khluu khluu changed the title [ci] Add grouped tests & mark tests to include for fastcheck pipeline [ci] Add grouped tests & mark tests to run by default for fastcheck pipeline Jul 12, 2024
@DarkLight1337
Copy link
Member

DarkLight1337 commented Jul 12, 2024

Is there a reason why we have to group the tests together rather than marking the individual tests fast_check? Having duplicate definitions in test-pipeline.yaml might lead to copy-and-paste mistakes.

@khluu
Copy link
Collaborator Author

khluu commented Jul 12, 2024

Is there a reason why we have to group the tests together rather than marking the individual tests fast_check?

It's mostly to save on launching instances & image pull overhead. Each job has to pull the Docker image which takes roughly 2-3 mins, while the test itself only runs for 3-4 mins... Grouping tests together like this can save like 10mins or more of billable time for each build

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jul 12, 2024

It's mostly to save on launching instances & image pull overhead. Each job has to pull the Docker image which takes roughly 2-3 mins, while the test itself only runs for 3-4 mins... Grouping tests together like this can save like 10mins or more of billable time for each build

If that's the case, perhaps we should get rid of the individual tests in favour of grouping them together, regardless of fast_check.

@khluu
Copy link
Collaborator Author

khluu commented Jul 12, 2024

It's mostly to save on launching instances & image pull overhead. Each job has to pull the Docker image which takes roughly 2-3 mins, while the test itself only runs for 3-4 mins... Grouping tests together like this can save like 10mins or more of billable time for each build

If that's the case, perhaps we should get rid of the individual tests in favour of grouping them together regardless of fast_check.

Yup I was planning to do that even for full CI run too, but let's start with fastcheck first

p
Signed-off-by: kevin <kevin@anyscale.com>
khluu added 2 commits July 12, 2024 06:56
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
@simon-mo
Copy link
Collaborator

  • What is fast_check_only?
  • Can we add docs build as well.

@simon-mo simon-mo merged commit b75bce1 into vllm-project:main Jul 12, 2024
72 checks passed
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
@Jeffwan
Copy link
Contributor

Jeffwan commented Jul 24, 2024

@khluu I am new to buildkite tool. I can not find fast_check in official docs. Is there something I am missing? https://buildkite.com/docs/pipelines/command-step#command-step-attributes

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
…ipeline (vllm-project#6365)

Signed-off-by: kevin <kevin@anyscale.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants