Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Cleanup VLM tests #6107

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Jul 3, 2024

The text conversion from vLLM to HF format was not entirely correct, resulting in some false positive warnings in VLM tests.

(Note: Text mismatches don't cause CI failures since we're now comparing results by token IDs, but such mismatches still emit a warning)

@DarkLight1337 DarkLight1337 changed the title [CI/Build] Cleanup vlm tests [CI/Build] Cleanup VLM tests Jul 3, 2024
@DarkLight1337 DarkLight1337 requested a review from ywang96 July 3, 2024 14:58
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ywang96 ywang96 merged commit 3dd5070 into vllm-project:main Jul 4, 2024
70 checks passed
@DarkLight1337 DarkLight1337 deleted the cleanup-vlm-tests branch July 4, 2024 04:51
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jul 7, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants