-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hardware][Intel CPU] Adding intel openmp tunings in Docker file #6008
Conversation
a45d5db
to
86ebb1d
Compare
86ebb1d
to
30ee3ce
Compare
This patch adds more tunins for CPU backend on intel openmp. These tunings improves CPU backend performance greatly, especially on throughput related tests. Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
551c442
to
bcd0c57
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
a198bfd
to
458db88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR!
b955cbf
to
90a1be3
Compare
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
90a1be3
to
ad4ac91
Compare
@@ -150,6 +150,9 @@ def __init__( | |||
if self.is_driver_worker: | |||
assert self.rank == 0, "The driver worker must have rank 0." | |||
|
|||
# try to initialize intel openmp optimized tunings | |||
init_kmp_env() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double-check whether the env variables are correctly used by the libraries. In my personal experience, some env variables have to be set before the libraries are loaded.
…m-project#6008) Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
…m-project#6008) Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
…m-project#6008) Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
…m-project#6008) Signed-off-by: Yuan Zhou <yuan.zhou@intel.com> Signed-off-by: Alvant <alvasian@yandex.ru>
This patch adds more tunings for CPU backend on intel openmp.
These tunings improves CPU backend performance greatly, especially on throughput related tests.
This patch also updates the CPU docker file to run the serving endpoint as entry point by default
FIX #xxxx (link existing issues this PR will resolve)
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!