[Bugfix] Fixed error in slice_lora_b for MergedQKVParallelLinearWithLora #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @Yard1. |
simon-mo
approved these changes
May 5, 2024
DarkLight1337
requested changes
May 6, 2024
|
Good point, it is done. Also updated the fully sharded layers to match. |
|
can you merge this plz |
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 8, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
May 19, 2024
rohithkrn
pushed a commit
to rohithkrn/vllm
that referenced
this pull request
May 20, 2024
dtrifiro
pushed a commit
to dtrifiro/vllm
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #3524
Fix #4605
MergedQKVParallelLinearWithLoraslice_lora_bthrows an error when the passed inlora_bcontains None.