Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel][Core][WIP] Tree attention and parallel decoding #4325

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yukavio
Copy link

@yukavio yukavio commented Apr 24, 2024

The implementation of tree attention which will been used for accelerating the speculative decodign and parallel decoding (with sampling params: n lager than 1 and beam_search = false. Theoretically, the case where beam_search=True can also be implemented, but it has not been implemented yet in this PR.)

@cadedaniel cadedaniel self-requested a review April 24, 2024 17:29
@mpjlu
Copy link

mpjlu commented May 30, 2024

@yukavio great work, will you continue work on this PR.

@yukavio
Copy link
Author

yukavio commented Jun 3, 2024

@yukavio great work, will you continue work on this PR.
There are certain performance issues with the kernel implemented using Triton. If a high acceleration ratio is required, it may be necessary to modify the implementation based on CUDA. However, I'm sorry to say that I currently don't have the time to complete this task.

Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale label Oct 29, 2024
Copy link

mergify bot commented Oct 29, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @yukavio please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants