Skip to content

Conversation

@zxdvd
Copy link
Contributor

@zxdvd zxdvd commented Apr 22, 2024

I'm try with speculative decoding and got problems with async engine. I think this fix it.
@cadedaniel Could you help to review this?

@zxdvd zxdvd changed the title Fix async executing of speculative decoding [Speculative decoding] Fix async executing Apr 22, 2024
@simon-mo simon-mo requested a review from cadedaniel April 22, 2024 16:42
@cadedaniel
Copy link
Collaborator

Will take a look today

@cadedaniel
Copy link
Collaborator

Hi @zxdvd , thanks for the PR!

  • Can you add the stacktrace of the crash you saw to the PR description?
  • Can you add a test for async engine + spec decode, so we catch this in the future?

@cadedaniel
Copy link
Collaborator

I put a suggestion here for how to do the async test #4165 (comment)

@comaniac
Copy link
Collaborator

@zxdvd thanks for the timely PR! We also need this fix to unblock performance evaluation of #4353 so it'd be better to get it merged ASAP. Did you get a chance working on this PR?

@cadedaniel
Copy link
Collaborator

cadedaniel commented Apr 29, 2024

I think this one is closer #4165 (edited with right link)

@zxdvd
Copy link
Contributor Author

zxdvd commented Apr 30, 2024

I'll close this since it is duplicated to #4165

@zxdvd zxdvd closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants