Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Define common requirements #3841

Merged
merged 17 commits into from
Apr 5, 2024
Prev Previous commit
Next Next commit
Merge branch 'main' into cleanup-req
  • Loading branch information
WoosukKwon committed Apr 5, 2024
commit 10ba462a4609d08409b7606f33b95362c3f6d5ef
17 changes: 2 additions & 15 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -128,22 +128,9 @@ FROM vllm-base AS test

ADD . /vllm-workspace/


#################### RUNTIME BASE IMAGE ####################
# We used base cuda image because pytorch installs its own cuda libraries.
# However pynccl depends on cuda libraries so we had to switch to the runtime image
# In the future it would be nice to get a container with pytorch and cuda without duplicating cuda
FROM nvidia/cuda:12.1.0-runtime-ubuntu22.04 AS vllm-base

# libnccl required for ray
RUN apt-get update -y \
&& apt-get install -y python3-pip

WORKDIR /workspace
COPY requirements-common.txt requirements-common.txt
COPY requirements-cuda.txt requirements-cuda.txt
# install development dependencies (for testing)
RUN --mount=type=cache,target=/root/.cache/pip \
pip install -r requirements-cuda.txt
pip install -r requirements-dev.txt

# doc requires source code
# we hide them inside `test_docs/` , so that this source code
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.