Skip to content

Remove unused EVS functions in qwen3_vl.py#37183

Merged
Isotr0py merged 1 commit intovllm-project:mainfrom
gty111:cleanup
Mar 16, 2026
Merged

Remove unused EVS functions in qwen3_vl.py#37183
Isotr0py merged 1 commit intovllm-project:mainfrom
gty111:cleanup

Conversation

@gty111
Copy link
Copy Markdown
Contributor

@gty111 gty111 commented Mar 16, 2026

Purpose

In qwen3_vl.py, functions including _get_evs_mask_segments, _extract_frame_offsets_from_mask, and _get_actual_frame_token_counts were introduced in #29752. However, their calls were removed in #33607 while their definitions were left untouched.
This PR removes the unused EVS-related functions from qwen3_vl.py.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Tianyu Guo <guoty9@mail2.sysu.edu.cn>
@gty111 gty111 requested a review from sighingnow as a code owner March 16, 2026 11:22
Copilot AI review requested due to automatic review settings March 16, 2026 11:22
@mergify mergify Bot added the qwen Related to Qwen models label Mar 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes EVS-related helper methods from qwen3_vl.py that were introduced earlier but no longer have any call sites after subsequent refactors, reducing dead code in the Qwen3-VL model implementation.

Changes:

  • Removed _get_evs_mask_segments, _extract_frame_offsets_from_mask, and _get_actual_frame_token_counts from Qwen3VLForConditionalGeneration.
  • Kept existing EVS-aware logic that now relies on token markers (vision_start_token_id / vision_end_token_id) for frame iteration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes three unused EVS-related functions (_get_evs_mask_segments, _extract_frame_offsets_from_mask, and _get_actual_frame_token_counts) from vllm/model_executor/models/qwen3_vl.py. This change cleans up dead code, which improves the maintainability of the codebase. I have confirmed that these functions are not called within the provided context. The change is correct and I have no further comments.

Copy link
Copy Markdown
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleanup!

@Isotr0py Isotr0py enabled auto-merge (squash) March 16, 2026 11:28
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 16, 2026
@Isotr0py Isotr0py merged commit 43a73f8 into vllm-project:main Mar 16, 2026
60 of 61 checks passed
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Mar 17, 2026
Signed-off-by: Tianyu Guo <guoty9@mail2.sysu.edu.cn>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
Signed-off-by: Tianyu Guo <guoty9@mail2.sysu.edu.cn>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: Tianyu Guo <guoty9@mail2.sysu.edu.cn>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
Signed-off-by: Tianyu Guo <guoty9@mail2.sysu.edu.cn>
mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request Apr 9, 2026
Signed-off-by: Tianyu Guo <guoty9@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants