Skip to content

[Quality] Add CI for formatting #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 3, 2023
Merged

[Quality] Add CI for formatting #343

merged 10 commits into from
Jul 3, 2023

Conversation

zhuohan123
Copy link
Member

@zhuohan123 zhuohan123 commented Jul 3, 2023

Completely close #57

@zhuohan123 zhuohan123 requested a review from WoosukKwon July 3, 2023 21:00
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Left some minor comments.

@zhuohan123 zhuohan123 merged commit 42e0c1d into main Jul 3, 2023
@zhuohan123 zhuohan123 deleted the format-ci branch July 3, 2023 21:51
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
Xaenalt referenced this pull request in opendatahub-io/vllm Oct 14, 2024
…th LoRA (#343)

This PR has following fixes,

- Increase size of indices tensors used to maintain multi-lora state
information from max_num_batched_tokens to 3*max_num_batched_tokens.
This increase is done to provide buffer for padding done in batch &
sequence dimensions.

- Move logic to remove padding from lora_logits from execute_model()
back to Class LogitsProcessorWithLoRA, this is done to fix race
condition caused by updating multi-lora state information directly.

FIX HabanaAI#237
billishyahao pushed a commit to billishyahao/vllm that referenced this pull request Dec 31, 2024
* Updated library versions

* Simple num_stages fix without re-tuning for performance

* Tuning script adaptation for the new triton

* navi lib versions

* Update MI300X fused_moe configs for Triton 3.2 (vllm-project#344)

---------

Co-authored-by: Jeremy Arnold <103538711+JArnoldAMD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code formatting script & Add CI to check code format
2 participants