Skip to content

[Doc] fix doc to install build requirement first #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

youkaichao
Copy link
Member

Running setup.py requires some packages like torch and packaging. We need to install them first before running python setup.py develop.

@youkaichao
Copy link
Member Author

When I try a fresh new installation, I met the following error:

The code uses transformers == 4.38.2, which imports huggingface_hub by default, but does not specify it in package dependencies :(

What a mess in package dependencies.

Do we need to specify huggingface_hub ourselves?

cc @WoosukKwon @zhuohan123 @simon-mo

@youkaichao
Copy link
Member Author

I also need the following things to make a fresh new installation work:

$ pip install regex safetensors tokenizers
$ pip install "numpy<2"

You know what? numpy just released 2.0.0 several days ago! Would break lots of code :(

@WoosukKwon
Copy link
Collaborator

pip install -e . is supposed to install torch (and others in pyproject.toml) first before executing setup.py.

@youkaichao
Copy link
Member Author

pip install -e . is supposed to install torch (and others in pyproject.toml) first before executing setup.py.

I'm using python setup.py develop. Maybe it works differently from pip install -e .

@esmeetu
Copy link
Member

esmeetu commented Mar 14, 2024

@youkaichao Maybe related this PR #2796 ? After pip install -e . once, developer can use python setup.py develop to reduce build time.

@WoosukKwon
Copy link
Collaborator

I believe @esmeetu is correct. Also, for Numpy, I believe v2 is not released yet.

@WoosukKwon WoosukKwon closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants