Skip to content

Conversation

simon-mo
Copy link
Collaborator

No description provided.

@simon-mo simon-mo marked this pull request as ready for review March 13, 2024 18:15
@simon-mo
Copy link
Collaborator Author

hmm no reproducible in my dev box

@simon-mo
Copy link
Collaborator Author

Ok i can repro on latest outlines

@robertgshaw2-redhat
Copy link
Collaborator

I'm seeing the same issue in my CI

@simon-mo
Copy link
Collaborator Author

Entrypoint test passed by pinning outlines to older version. merging

@simon-mo simon-mo merged commit 81653d9 into vllm-project:main Mar 14, 2024
robertgshaw2-redhat added a commit to neuralmagic/nm-vllm that referenced this pull request Mar 14, 2024
SUMMARY:
Skips test causing nightly failure for the short term
-
https://github.com/neuralmagic/nm-vllm/actions/runs/8257372912/job/22587806623#step:9:1296

Issue is related to an experimental feature called guided generation.
Upstream team is working on resolving via
vllm-project#3383.

Change will cause merge conflicts with upstream. During next upstream
sync where they have fixed the issue, we can turn this test back on

TEST PLAN:
Automation
@robertgshaw2-redhat
Copy link
Collaborator

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants