Move model filelocks from /tmp/
to ~/.cache/vllm/locks/
dir
#3241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating and accessing filelocks in the global
/tmp/
directory that are based on model names becomes problematic on multi-user systems since if one user runsLLM("facebook/opt-125")
, then a filelock is created at/tmp/facebook-opt-125m.lock
and left there. This is fine if a single user is doing this, but as soon as another user runsLLM("facebook/opt-125")
, then vLLM will try to access the filelock that another user made, which they will not have permission for, triggering:This PR attempts to resolve this by using a user's local
~/.cache/vllm/locks
directory to create and access locks, preventing file permissions conflicts with other users.Addresses: #2179 #2232 #2675