kv_transfer: Rename the shared storage connectors #30201
Conversation
orozery
requested review from
ApostaC,
NickLucche,
WoosukKwon,
alexm-redhat,
heheda12345,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
|
Documentation preview: https://vllm--30201.org.readthedocs.build/en/30201/ |
mergify
bot
added
documentation
|
This pull request has merge conflicts that must be resolved before it can be |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames SharedStorageConnector to ExampleConnector and ECSharedStorageConnector to ECExampleConnector to better reflect their purpose as example implementations. The renaming is applied consistently across a large number of files. However, I've identified a critical issue where a related connector file was renamed inconsistently, which will lead to an ImportError and break one of the examples. Please see the detailed comment for the fix.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This commit renames the {EC}SharedStorageConnectors to {EC}ExampleConnectors.
This makes it clear that these connectors should be treated as examples for connector developers,
and not as actual production-worthy shared storage connectors.
Signed-off-by: Or Ozeri <oro@il.ibm.com>
orozery
force-pushed
the
exmaple-connector
branch
from
0693bcf to
a812e1c
Compare
|
cc @markmc |
1 participant
This PR renames the {EC}SharedStorageConnectors to {EC}ExampleConnectors. This makes it clear that these connectors should be treated as examples for connector developers, and not as actual production-worthy shared storage connectors.