let draft model follow target model's config_format #30152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: internally we use a custom plugin to handle our customized config format, without this change, draft model config will be default to "auto", this has caused mismatches Test Plan: CI Differential Revision: D88501036
bangshengtang
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue in speculative decoding where the draft model did not inherit the config_format from the target model. This could lead to mismatches, especially when using custom configuration formats handled by plugins. The proposed change correctly propagates the config_format from the target model's configuration to the draft model's configuration during its initialization. The fix is concise, targeted, and appears correct. I have no further comments.
zhuohan123
approved these changes
Dec 5, 2025
github-actions
bot
added
the
ready
yewentao256
approved these changes
Dec 5, 2025
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
Collaborator
Author
|
hmm, @zhuohan123 @yewentao256 the CI failure seems irrelevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: internally we use a custom plugin to handle our customized config format, without this change, draft model config will be default to "auto", this has caused mismatches
Test Plan: CI
Differential Revision: D88501036