Skip to content

Conversation

@xu-song
Copy link
Contributor

@xu-song xu-song commented Dec 5, 2025

Purpose

rust style regex is a bit different from python regex. For example, ^(?!abc) is not supported in rust regex.

error: look-around, including look-ahead and look-behind, is not supported

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Xu Song <xusong.vip@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a note to the documentation specifying that regex patterns for structured outputs should follow Rust style. While this is true for several backends, it's not universally correct, as the lm-format-enforcer backend uses Python's re module. I've added a comment to suggest a more precise clarification to prevent misleading users and causing potential runtime errors.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Xu Song <xusong.vip@gmail.com>
@mergify
Copy link

mergify bot commented Dec 5, 2025

Documentation preview: https://vllm--30106.org.readthedocs.build/en/30106/

@mergify mergify bot added documentation Improvements or additions to documentation structured-output labels Dec 5, 2025
Signed-off-by: Xu Song <xusong.vip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation structured-output

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant