-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[FIX]Patch run-cluster.sh (fix for #28328) #30002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[FIX]Patch run-cluster.sh (fix for #28328) #30002
Conversation
|
Documentation preview: https://vllm--30002.org.readthedocs.build/en/30002/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to simplify how the node IP address is passed to Ray for multi-NIC setups. The change for the head node is correct, but the implementation for worker nodes introduces a bug where the VLLM_HOST_IP variable is used without being defined, breaking the intended functionality. I've provided a critical review comment with a suggested fix to correctly parse the worker IP from the arguments.
Signed-off-by: Ev Lacey <github@everettlacey.com>
|
cc @mgoin |
Purpose
This PR corrects the addition for 28328 by removing the new block to build vLLM variables and instead just adds the node ip address to the ray start command. This fixes any issues when a device has multiple interfaces.
Use case: Device has ethernet & QSFP cabling and we want ray to serve over the high speed link.
Test Plan
In our scenario we are running 2x devices with 2 interfaces each -- one ethernet cable providing internet access and one QSFP cable connecting the two servers directly (P2P). We want to confirm the arguments passed to the run_cluster.sh script respect these input arguments and that Ray itself selects the P2P QSFP interfaces, instead of the default behavior to select the ethernet interface (public IP address) of both nodes.
Test Result
From node 1:
From Node 2
Ray status:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.