Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Nov 14, 2025

This more accurately describes what it does. This change should prevent confusion about if vLLM is the one doing the execution.

…eling backend`

This more accurately describes what it does. This change should prevent confusion about if vLLM is the one doing the execution.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify
Copy link

mergify bot commented Nov 14, 2025

Documentation preview: https://vllm--28725.org.readthedocs.build/en/28725/

@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Nov 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the name of Transformers backend to Transformers modeling backend throughout the codebase. This change improves clarity and more accurately describes the feature's function, preventing potential confusion. The changes are applied consistently across documentation, comments, and user-facing messages. The pull request is well-executed and I approve of the changes.

@Isotr0py Isotr0py enabled auto-merge (squash) November 14, 2025 14:23
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 14, 2025
@Isotr0py Isotr0py merged commit 5f3cd7f into vllm-project:main Nov 14, 2025
62 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Transformers backend Nov 14, 2025
@hmellor hmellor deleted the update-transformers-backend-name branch November 14, 2025 17:01
geodavic pushed a commit to geodavic/vllm that referenced this pull request Nov 16, 2025
…eling backend` (vllm-project#28725)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: George D. Torres <gdavtor@gmail.com>
bwasti pushed a commit to bwasti/vllm that referenced this pull request Nov 17, 2025
…eling backend` (vllm-project#28725)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Bram Wasti <bwasti@meta.com>
tianyu-l pushed a commit to pytorch/torchtitan that referenced this pull request Nov 23, 2025
following Huggingface efforts in VLLM (cf
vllm-project/vllm#28725), we would like to
uniformize the naming and make sure that people think we use the HF
models only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants