fix passing hf_config args: #2547 #2670
Open
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fix addresses issue #2547
I followed what Simon Mo suggested and modified EngineArgs and the ModelConfig class.
Here are the following changes i made:
args_utils.py
changed the
EngineArgs
class definition to include a new argument:hf_kwargs: Optional[dict] = None
In
create_engine_configs
, I passed this in to theModelConfig
instantiation as follows:hf_kwargs=(self.hf_kwargs or {})
vllm/config.py
In
__ init__
function, I added the same argument:hf_kwargs: Optional[dict] = None
I unpacked this in the
get_config
function call as follows:**hf_kwargs
transformers_utils/config.py
added
**hf_kwargs
to theget_config
function definitioninserted
hf_kwargs
into theAutoConfig.pretrained
call