[Log] Optimize Startup Log #26601
Merged
[Log] Optimize Startup Log #26601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yewentao256 <zhyanwentao@126.com>
yewentao256
requested review from
LucasWilkinson,
WoosukKwon,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully optimizes the startup logging by preventing duplicate log entries in distributed environments and adjusting the verbosity of several messages. The use of is_global_first_rank() is correctly applied to ensure that initialization messages are logged only by a single process. Additionally, changing some log levels from INFO or WARNING to DEBUG and removing a redundant message helps to create a cleaner and more focused log output. The changes are consistent and improve the overall user experience during startup. No high or critical severity issues were found.
njhill
reviewed
Oct 11, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
1994
pushed a commit
to 1994/vllm
that referenced
this pull request
Oct 14, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: 1994 <1994@users.noreply.github.com>
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Nov 12, 2025
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose