Fix test_mamba_ssm_ssd.py due to missing _query_start_loc_to_chunk_indices_offsets #25995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hl475
changed the title
hl475
force-pushed
the
fix_mamba_test
branch
from
2019c24 to
25a53dc
Compare
hl475
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth and
yewentao256
as code owners
tdoublep
reviewed
Oct 1, 2025
| chunk_lens.append(int(take)) | ||
| seq_idx_chunks.append(b) | ||
| last_chunk_indices[b] = len(chunk_lens) - 1 | ||
| pos += take |
There was a problem hiding this comment.
Rather than re-implementing this logic - I think it could be better to refactor the logic into a util function in the meta-data builder and import it (e.g., similarly to how we were doing it for _query_start_loc_to_chunk_indices_offsets).
There was a problem hiding this comment.
thanks @tdoublep !
I moved this helper function to vllm/v1/attention/backends/mamba2_attn.py . Let me know what you think!
Signed-off-by: Huamin Li <3ericli@gmail.com>
Regarding this, from https://github.com/vllm-project/vllm/blob/main/.buildkite/test-pipeline.yaml#L473C10-L480 , my guess is it will run only if changes touch Your PR didn't touch those directories so it didn't get triggered. Let me know if you want to change that, and I am happy to add vllm/v1/attention/backends/mamba2_attn.py into the list! |
mgoin
approved these changes
Oct 1, 2025
github-actions
bot
added
the
ready
pdasigi
pushed a commit
to pdasigi/vllm
that referenced
this pull request
Oct 2, 2025
…dices_offsets (vllm-project#25995) Signed-off-by: Huamin Li <3ericli@gmail.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…dices_offsets (#25995) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
tomeras91
pushed a commit
to tomeras91/vllm
that referenced
this pull request
Oct 6, 2025
…dices_offsets (vllm-project#25995) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…dices_offsets (vllm-project#25995) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…dices_offsets (vllm-project#25995) Signed-off-by: Huamin Li <3ericli@gmail.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…dices_offsets (vllm-project#25995) Signed-off-by: Huamin Li <3ericli@gmail.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…dices_offsets (vllm-project#25995) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#24683 removed the helper function _query_start_loc_to_chunk_indices_offsets and breaks the tests/kernels/mamba/test_mamba_ssm_ssd.py (sample job https://buildkite.com/vllm/ci/builds/32891/steps/canvas?sid=019998c8-1682-4e2d-8161-55a772c16cde) from v1.attention.backends.mamba2_attn as part of the chunk‑aligned Mamba2 changes. This made tests/kernels/mamba/test_mamba_ssm_ssd.py fail at import time. This patch removes the import and computes the small piece of chunk metadata directly in the test, also providing cu_chunk_seqlens and last_chunk_indices expected by the new kernels. No runtime changes.
This PR
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.