-
-
Couldn't load subscription status.
- Fork 10.8k
[CI/Build] Fix disabled v1 attention backend selection test #25471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request re-enables a disabled test for the v1 attention backend selection and corrects an import path within it. The changes are straightforward and correct, successfully fixing the test as described. I find no issues with this update.
…ject#25471) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ject#25471) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…ject#25471) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: gaojc <1055866782@qq.com>
…ject#25471) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…ject#25471) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ject#25471) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ject#25471) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
test_envtest intests/kernels/attention/test_attention_selector.pyTest Plan
Test Result
All tests should pass now:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.