Skip to content

[benchmarks]allow skip ready check for bench serve #25420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 23, 2025
Merged

[benchmarks]allow skip ready check for bench serve #25420

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b96ac42
allow skip ready check for bench serve
Sep 22, 2025
9517382
Update vllm/benchmarks/serve.py
luccafong Sep 22, 2025
f52445d
switch to reuse ready_check_timeout_sec=0
luccafong Sep 22, 2025
83c6dde
Merge branch 'main' into export-D82995002
ywang96 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions vllm/benchmarks/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,18 +531,22 @@ async def benchmark(
extra_body=extra_body,
)

test_output = await wait_for_endpoint(
request_func,
test_input,
session,
timeout_seconds=ready_check_timeout_sec,
)
if not test_output.success:
raise ValueError(
"Initial test run failed - Please make sure benchmark arguments "
f"are correctly specified. Error: {test_output.error}")
if ready_check_timeout_sec > 0:
test_output = await wait_for_endpoint(
request_func,
test_input,
session,
timeout_seconds=ready_check_timeout_sec,
)
if not test_output.success:
raise ValueError(
"Initial test run failed - Please make sure benchmark "
"arguments are correctly specified. "
f"Error: {test_output.error}")
else:
print("Initial test run completed. Starting main benchmark run...")
else:
print("Initial test run completed. Starting main benchmark run...")
print("Skipping endpoint ready check.")

if lora_modules:
# For each input request, choose a LoRA module at random.
Expand Down Expand Up @@ -1151,7 +1155,8 @@ def add_cli_args(parser: argparse.ArgumentParser):
type=int,
default=600,
help="Maximum time to wait for the endpoint to become ready "
"in seconds (default: 600 seconds / 10 minutes).",
"in seconds (default: 600 seconds / 10 minutes). If set to 0, "
"the ready check will be skipped."
)


Expand Down