Skip to content

[Bugfix] fix tool call arguments is empty #25223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2025
Merged

[Bugfix] fix tool call arguments is empty #25223

merged 5 commits into from
Sep 20, 2025

Conversation

@chaunceyjiang
Copy link
Collaborator

@chaunceyjiang chaunceyjiang commented Sep 19, 2025 •
edited by github-actions bot
Loading

Purpose

FIX #19419

Test Plan

see e2e test

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@chaunceyjiang @my-git9
[Bugfix] fix tool call arguments is empty
6ad41d7 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
@mergify mergify bot added the frontend label Sep 19, 2025
@chaunceyjiang
[Bugfix] fix tool call arguments is empty
0bab4b7 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang chaunceyjiang marked this pull request as ready for review September 19, 2025 03:59
@chaunceyjiang
[Bugfix] fix tool call arguments is empty
a5a50f5 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
simon-mo
simon-mo approved these changes Sep 19, 2025
View reviewed changes
@chaunceyjiang
[Bugfix] fix tool call arguments is empty
4a08d9d 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Bugfix] fix tool call arguments is empty
8a3c375 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Collaborator Author

chaunceyjiang commented Sep 19, 2025

/cc @DarkLight1337 PTAL.

@chaunceyjiang chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 20, 2025
@chaunceyjiang chaunceyjiang mentioned this pull request Sep 20, 2025
Open
5 tasks
@DarkLight1337 DarkLight1337 merged commit f91480b into vllm-project:main Sep 20, 2025
52 checks passed
@chaunceyjiang chaunceyjiang deleted the fix_empty_arguments branch September 22, 2025 08:16
@chaunceyjiang chaunceyjiang mentioned this pull request Sep 25, 2025
Open
1 task
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@chaunceyjiang @my-git9 @FeiDaLI
[Bugfix] fix tool call arguments is empty (vllm-project#25223)
cdca890 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@chaunceyjiang @my-git9 @charlifu
[Bugfix] fix tool call arguments is empty (vllm-project#25223)
3e213d4 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
Signed-off-by: charlifu <charlifu@amd.com>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
@chaunceyjiang @my-git9 @yewentao256
[Bugfix] fix tool call arguments is empty (#25223)
239aef5 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@chaunceyjiang @my-git9 @xuebwang-amd
[Bugfix] fix tool call arguments is empty (vllm-project#25223)
2d8f910 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@chaunceyjiang @my-git9 @choprahetarth
[Bugfix] fix tool call arguments is empty (vllm-project#25223)
22e30a8 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@chaunceyjiang @my-git9 @lywa1998
[Bugfix] fix tool call arguments is empty (vllm-project#25223)
9818654 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@chaunceyjiang @my-git9 @xuebwang-amd
[Bugfix] fix tool call arguments is empty (vllm-project#25223)
03b1f1a 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Co-authored-by: xin.li <xin.li@daocloud.io>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo simon-mo approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

@NickLucche NickLucche Awaiting requested review from NickLucche NickLucche is a code owner

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: JSON decode error when tool call argument is empty

3 participants

@chaunceyjiang @simon-mo @DarkLight1337