Skip to content

[V0 Deprecation] Remove V0 Core tests #25082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

[V0 Deprecation] Remove V0 Core tests #25082

merged 2 commits into from
Sep 17, 2025

Conversation

@WoosukKwon
Copy link
Collaborator

No description provided.

@WoosukKwon
[V0 Deprecation] Remove V0 core tests
64e5417 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon
ci
f388e38 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@mergify mergify bot added the ci/build label Sep 17, 2025
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 17, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the V0 core tests. However, the corresponding V0 implementation in vllm/core is not removed, which leaves a significant part of the codebase without test coverage. This is a critical issue that needs to be addressed.

@WoosukKwon WoosukKwon merged commit 4b946d6 into main Sep 17, 2025
13 of 25 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/remove-v0-core-tests branch September 17, 2025 16:32
@mgoin
Copy link
Member

mgoin commented Sep 17, 2025

@WoosukKwon this broke a few tests on main. Why would you force this without letting the CI run?
Screenshot 2025-09-17 at 1 52 23 PM

@WoosukKwon
Copy link
Collaborator Author

@mgoin Thanks for letting me know. Apologies for that. I searched tests.core and didn't find anything, so I thought the files were safe to delete. Fixed the issue in #25087

@mgoin mgoin mentioned this pull request Sep 17, 2025
Closed
5 tasks
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@WoosukKwon @FeiDaLI
[V0 Deprecation] Remove V0 Core tests (vllm-project#25082)
8428c72 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@WoosukKwon @charlifu
[V0 Deprecation] Remove V0 Core tests (vllm-project#25082)
b25143e 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: charlifu <charlifu@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@WoosukKwon @xuebwang-amd
[V0 Deprecation] Remove V0 Core tests (vllm-project#25082)
e65bdc9 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@WoosukKwon @choprahetarth
[V0 Deprecation] Remove V0 Core tests (vllm-project#25082)
b57df7d 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@WoosukKwon @xuebwang-amd
[V0 Deprecation] Remove V0 Core tests (vllm-project#25082)
acfd7b4 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

V0 Deprecation
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WoosukKwon @mgoin