-
-
Couldn't load subscription status.
- Fork 10.9k
[CI Bugfix] Fix failing test_invalid_env #25078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a CI bugfix that updates an assertion in test_invalid_env to match a changed error message. The test verifies that setting an invalid attention backend via an environment variable raises a ValueError. The change updates the expected error message substring from "Invalid attention backend: 'INVALID'" to "Invalid value 'INVALID'". This change appears to be correct for the purpose of fixing the failing test. The new error message is less descriptive, which could be a minor regression in user experience, but the change in the test itself is sound. I did not find any issues with high or critical severity in this change.
|
Force merging to fix CI. Tested locally and precommit passes |
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
The Kernels Attention Test job didn't run when #24761 landed
https://buildkite.com/vllm/ci/builds/31128/steps/canvas?jid=019957f9-c996-474a-8f31-03ce4d94f5f5
Test Plan
Test Result
Tested locally
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.