Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Sep 17, 2025

Purpose

AutoModelForVision2Seq is now deprecated in Transformers and should be replaced by AutoModelForImageText2Text

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 17, 2025
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Sep 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the deprecated AutoModelForVision2Seq with AutoModelForImageTextToText across various test configurations in tests/models/multimodal/generation/test_common.py. This change aligns the codebase with the updated transformers library API, ensuring future compatibility and removing deprecation warnings. The modifications are straightforward and have been applied consistently. I find no issues with this change.

@Isotr0py Isotr0py enabled auto-merge (squash) September 17, 2025 10:54
@Isotr0py Isotr0py merged commit e120533 into vllm-project:main Sep 17, 2025
25 of 26 checks passed
@DarkLight1337 DarkLight1337 deleted the use-it2t branch September 17, 2025 12:52
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
…#25065)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
…#25065)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: charlifu <charlifu@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
…#25065)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
…#25065)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
…#25065)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants