Skip to content

Conversation

@samzong
Copy link
Contributor

@samzong samzong commented Sep 17, 2025

Purpose

fix griffe build warning.

modified:   vllm/benchmarks/serve.py
modified:   vllm/distributed/eplb/eplb_state.py
modified:   vllm/distributed/eplb/rebalance_algo.py

sources:

WARNING -  griffe: vllm/benchmarks/serve.py:141: Confusing indentation for continuation line 17 in docstring, should be 4 * 2 = 8 spaces, not 5

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a series of formatting and documentation improvements across several files. The changes primarily focus on fixing indentation in docstrings, reformatting import statements for better readability, and enhancing the clarity of function return value descriptions in docstrings. These modifications are consistent with the goal of eliminating griffe build warnings and improving overall code maintainability. The changes are well-executed and I have no further suggestions.

@mergify mergify bot added the performance Performance-related issues label Sep 17, 2025
@samzong samzong force-pushed the style/docstring-warning branch from 1a27422 to f6a9bf5 Compare September 17, 2025 01:19
@samzong samzong changed the title improve code formatting and comments for better readability and maintainability.eliminate griffe build warning. [Docs] improve code formatting and comments for better readability and maintainability.eliminate griffe build warning. Sep 17, 2025
@samzong samzong changed the title [Docs] improve code formatting and comments for better readability and maintainability.eliminate griffe build warning. [Docs] improve code formatting and comments for eliminate griffe build warning. Sep 17, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! cc @hmellor

@mgoin mgoin added documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed and removed performance Performance-related issues labels Sep 17, 2025
@mgoin mgoin requested a review from hmellor September 17, 2025 02:13
@mergify mergify bot added the performance Performance-related issues label Sep 17, 2025
@windsonsea
Copy link
Contributor

Related to issue #25020

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the whole shapes onto the next line so it's easier to read?

@samzong samzong force-pushed the style/docstring-warning branch from f6a9bf5 to 9cd3806 Compare September 17, 2025 13:50
…ainability.eliminate griffe build warning.

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong force-pushed the style/docstring-warning branch from 9cd3806 to 5064308 Compare September 17, 2025 13:54
@simon-mo simon-mo merged commit 47f670b into vllm-project:main Sep 17, 2025
13 of 16 checks passed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
…d warning. (vllm-project#25010)

Signed-off-by: samzong <samzong.lu@gmail.com>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
…d warning. (vllm-project#25010)

Signed-off-by: samzong <samzong.lu@gmail.com>
Signed-off-by: charlifu <charlifu@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
…d warning. (vllm-project#25010)

Signed-off-by: samzong <samzong.lu@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
…d warning. (vllm-project#25010)

Signed-off-by: samzong <samzong.lu@gmail.com>
sducouedic pushed a commit to sducouedic/vllm that referenced this pull request Oct 16, 2025
…d warning. (vllm-project#25010)

Signed-off-by: samzong <samzong.lu@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
…d warning. (vllm-project#25010)

Signed-off-by: samzong <samzong.lu@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants