-
-
Couldn't load subscription status.
- Fork 10.9k
[Docs] improve code formatting and comments for eliminate griffe build warning. #25010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a series of formatting and documentation improvements across several files. The changes primarily focus on fixing indentation in docstrings, reformatting import statements for better readability, and enhancing the clarity of function return value descriptions in docstrings. These modifications are consistent with the goal of eliminating griffe build warnings and improving overall code maintainability. The changes are well-executed and I have no further suggestions.
1a27422 to
f6a9bf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! cc @hmellor
|
Related to issue #25020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move the whole shapes onto the next line so it's easier to read?
f6a9bf5 to
9cd3806
Compare
…ainability.eliminate griffe build warning. Signed-off-by: samzong <samzong.lu@gmail.com>
9cd3806 to
5064308
Compare
…d warning. (vllm-project#25010) Signed-off-by: samzong <samzong.lu@gmail.com>
…d warning. (vllm-project#25010) Signed-off-by: samzong <samzong.lu@gmail.com> Signed-off-by: charlifu <charlifu@amd.com>
…d warning. (vllm-project#25010) Signed-off-by: samzong <samzong.lu@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…d warning. (vllm-project#25010) Signed-off-by: samzong <samzong.lu@gmail.com>
…d warning. (vllm-project#25010) Signed-off-by: samzong <samzong.lu@gmail.com>
…d warning. (vllm-project#25010) Signed-off-by: samzong <samzong.lu@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
fix griffe build warning.
sources:
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.