-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[CI] Split pooling from entrypoints Test #24632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dfe10e3 to
fe9ee94
Compare
Signed-off-by: wang.yuqi <noooop@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the CI pipeline by splitting the pooling tests into a dedicated job. The file moves and import path updates are correct and improve the project structure. However, I've identified a potential issue with the new CI job's configuration: the timeout is set to a very high value of 130 minutes, which could impact CI performance and cost. I recommend reviewing this setting.
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: wang.yuqi <noooop@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
refactoring following #22992
Split pooling from entrypoints Test to Entrypoints Integration Test (Pooling) ~19 minutes
cc @DarkLight1337 @maxdebayser
Test Plan
pytest -v -s entrypoints/pooling
Test Result
keep ci green
Known Issues
entrypoints-integration-test-api-server still takes a long time ~1 hour, 49 minutes, we may need to split it further
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.