[RL] fast weight update with zmq + ipc handles #24295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weixiao-huang
requested review from
WoosukKwon,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new mechanism for fast, in-place model weight updates using ZMQ for inter-process communication, which is a good improvement for RLHF-style workloads. The implementation on the worker side is mostly solid, but it relies on a brittle internal detail of PyTorch. Additionally, the example script demonstrating this feature contains a performance bottleneck that undermines the goal of "fast" updates. My review provides suggestions to address these issues.
weixiao-huang
force-pushed
the
feat/fast-inplace-model-update
branch
from
05a7b7d to
198631d
Compare
youkaichao
reviewed
Sep 6, 2025
|
This pull request has merge conflicts that must be resolved before it can be |
youkaichao
reviewed
Sep 6, 2025
youkaichao
reviewed
Sep 6, 2025
weixiao-huang
force-pushed
the
feat/fast-inplace-model-update
branch
from
e63d2e7 to
348093a
Compare
youkaichao
reviewed
Sep 8, 2025
weixiao-huang
force-pushed
the
feat/fast-inplace-model-update
branch
from
348093a to
a64f369
Compare
youkaichao
reviewed
Sep 8, 2025
youkaichao
reviewed
Sep 8, 2025
youkaichao
reviewed
Sep 8, 2025
youkaichao
reviewed
Sep 8, 2025
youkaichao
reviewed
Sep 8, 2025
Signed-off-by: huangweixiao <huangweixiao@msh.team>
Signed-off-by: huangweixiao <huangweixiao@msh.team>
weixiao-huang
force-pushed
the
feat/fast-inplace-model-update
branch
2 times, most recently
from
1cfe7fb to
b73dc08
Compare
Signed-off-by: huangweixiao <huangweixiao@msh.team>
weixiao-huang
force-pushed
the
feat/fast-inplace-model-update
branch
from
b73dc08 to
35e57e5
Compare
Signed-off-by: youkaichao <youkaichao@gmail.com>
youkaichao
changed the title
github-actions
bot
added
the
ready
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
Signed-off-by: huangweixiao <huangweixiao@msh.team> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
Signed-off-by: huangweixiao <huangweixiao@msh.team> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: huangweixiao <huangweixiao@msh.team> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: huangweixiao <huangweixiao@msh.team> Signed-off-by: youkaichao <youkaichao@gmail.com> Co-authored-by: youkaichao <youkaichao@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolve #24163
Test Plan
Test Result
rlhf_colocate.pyis executed successfully