Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Aug 26, 2025

Purpose

Since we now support FlexAttention: https://github.com/vllm-project/vllm/blob/main/vllm/platforms/cuda.py#L332

V1 Engine should be allowed for older devices as well.

FIX #23531

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the V1 engine for GPUs with a compute capability of less than 8.0. This is achieved by removing a check that previously restricted V1 to newer GPUs. The change is justified by the integration of the FlexAttention backend, which is designed to support these older architectures within the V1 engine. The modification is localized and appears consistent with the existing attention backend selection logic. I have not identified any issues with this change.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but can we test this?

@DarkLight1337
Copy link
Member Author

I don't have access to such a device, so I'll wait for the OP in #23531 to comment on this

@DarkLight1337 DarkLight1337 changed the title [V1] Enable V1 for compute capability < 8.0 [V1] Enable V1 for compute capability < 8.0 + FP32 Aug 26, 2025
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this on a T4 machine earlier, can confirm flex attention working with fp32.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 26, 2025 07:48
@vllm-bot vllm-bot merged commit 50fede6 into vllm-project:main Aug 26, 2025
39 of 41 checks passed
@DarkLight1337 DarkLight1337 deleted the sm-v1 branch August 26, 2025 10:00
tc-mb pushed a commit to tc-mb/vllm that referenced this pull request Aug 27, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: tc-mb <caitianchi@modelbest.cn>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Prefix Caching is not enabled for CLS inference mode on TESLA T4 GPU

4 participants