-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Spec Decode][Benchmark] Add Blitzedit dataset #23605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR adds support for the Blitzedit dataset for benchmarking. The changes correctly add command-line arguments, integrate the new dataset class into the factory function, and implement the dataset loading and sampling logic. My review focuses on cleaning up some leftover debugging code and unused variables in the new BlazeditDataset
implementation to improve code quality and ensure the dataset is not unnecessarily filtered.
Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
Head branch was pushed to by a user without write access
65672e8
to
75103ca
Compare
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
Can you share some numbers of |
I have some numbers here: #18971 |
Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com> Co-authored-by: Roger Wang <hey@rogerw.io>
I have been looking for datasets where Ngram is better than Eagle for exploring the idea of combining Ngram and EAGLE #18633.
InstructCoder
being an editing task was the go to dataset in vLLM for Ngram until I found that fixing the prompt made EAGLE quite strong and better than Ngram on InstructCoder dataset. An ideal dataset would be the one where the overlap bw input and output are high.Blazedit
dataset is a promising one since it can allow observing AL of Ngram over different input-output overlap.Blazedit
dataset.vdaita/edit_5k_char
) and 10k char (vdaita/edit_10k_char
)Sample Cmd:
time VLLM_USE_V1=1 python3 examples/offline_inference/spec_decode.py --method eagle --num_spec_tokens 3 --tp 1 --dataset-name hf --dataset-path vdaita/edit_5k_char --num-prompts 90 --hf-output-len 2048 --blazedit-min-distance 0.01 --blazedit-max-distance 0.99 --print-output