Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Aug 20, 2025

Purpose

Fix CI failure introduced by #23190

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin added the ci-failure Issue about an unexpected test failure in CI label Aug 20, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a CI failure by removing the deprecated --enable-prompt-adapter command-line argument. The change is confined to vllm/engine/arg_utils.py and is a clean removal of a no-op argument. I have verified that there are no remaining usages of this argument within the provided codebase, making this a safe and correct change. I approve of this fix.

@mgoin mgoin enabled auto-merge (squash) August 20, 2025 23:27
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 20, 2025
@huydhn huydhn mentioned this pull request Aug 20, 2025
10 tasks
@simon-mo simon-mo merged commit bbea1ce into vllm-project:main Aug 21, 2025
40 of 51 checks passed
@mgoin mgoin deleted the fully-remove-prompt-adapter branch August 21, 2025 00:19
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
…oject#23284)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…oject#23284)

Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants