Skip to content

[Misc] refactor function name #23029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

andyxning
Copy link
Contributor

@andyxning andyxning commented Aug 16, 2025

Purpose

The function get_allowed_cpu_memory_node_list returns cpu id, physical core, numa node. It has nothing to do with memory.

Test Plan

NA

Test Result

NA

(Optional) Documentation Update

NA

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Aug 16, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors the function get_allowed_cpu_memory_node_list to get_allowed_cpu_core_node_list. This change is a clear improvement, as the new name accurately describes the function's purpose of retrieving CPU core and NUMA node information, which has no direct relation to memory as the old name suggested. The refactoring is applied consistently where the function is defined and used. This enhances code readability and maintainability. The change is correct and I have no further recommendations.

@andyxning andyxning force-pushed the refactor_function_name branch from 7a5a8c3 to 22b30c5 Compare August 17, 2025 00:30
Copy link
Collaborator

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 17, 2025
@yewentao256 yewentao256 enabled auto-merge (squash) August 17, 2025 13:18
auto-merge was automatically disabled August 17, 2025 16:20

Head branch was pushed to by a user without write access

@andyxning andyxning force-pushed the refactor_function_name branch from 22b30c5 to 82a8e4d Compare August 17, 2025 16:20
Signed-off-by: Andy Xie <andy.xning@gmail.com>
@andyxning andyxning force-pushed the refactor_function_name branch from 82a8e4d to 922c46d Compare August 18, 2025 02:26
@vllm-bot vllm-bot merged commit 08d5f71 into vllm-project:main Aug 18, 2025
36 of 38 checks passed
@andyxning andyxning deleted the refactor_function_name branch August 18, 2025 06:04
hustxiayang pushed a commit to hustxiayang/vllm that referenced this pull request Aug 19, 2025
Signed-off-by: Andy Xie <andy.xning@gmail.com>
princepride pushed a commit to princepride/vllm that referenced this pull request Aug 20, 2025
Signed-off-by: Andy Xie <andy.xning@gmail.com>
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
Signed-off-by: Andy Xie <andy.xning@gmail.com>
cyang49 pushed a commit to cyang49/vllm that referenced this pull request Aug 20, 2025
Signed-off-by: Andy Xie <andy.xning@gmail.com>
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 21, 2025
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Boyuan Feng <boyuan@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants