-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Misc] refactor function name #23029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request refactors the function get_allowed_cpu_memory_node_list
to get_allowed_cpu_core_node_list
. This change is a clear improvement, as the new name accurately describes the function's purpose of retrieving CPU core and NUMA node information, which has no direct relation to memory as the old name suggested. The refactoring is applied consistently where the function is defined and used. This enhances code readability and maintainability. The change is correct and I have no further recommendations.
7a5a8c3
to
22b30c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
Head branch was pushed to by a user without write access
22b30c5
to
82a8e4d
Compare
Signed-off-by: Andy Xie <andy.xning@gmail.com>
82a8e4d
to
922c46d
Compare
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Boyuan Feng <boyuan@meta.com>
Purpose
The function
get_allowed_cpu_memory_node_list
returns cpu id, physical core, numa node. It has nothing to do withmemory
.Test Plan
NA
Test Result
NA
(Optional) Documentation Update
NA
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.