Skip to content

Conversation

@huachenheli
Copy link
Contributor

@huachenheli huachenheli commented Aug 15, 2025

Summary:
Currently when ShareGPT4V dataset is used, the image data is not passed to the vLLM server correctly. This PR fixes the issue.

Test Plan:
vLLM:

python -m vllm.entrypoints.openai.api_server --model Qwen/Qwen2.5-VL-7B-Instruct --port 8001 --host 0.0.0.0 --dtype bfloat16 --limit-mm-per-prompt '{"image": 1, "video":1}' --allowed-local-media-path /home/huachenheli/datasets/COCO/train2017

Request sender:

python benchmarks/benchmark_serving.py --backend openai-chat --model Qwen/Qwen2.5-VL-7B-Instruct --dataset-name sharegpt --dataset-path ../ShareGPT4V/sharegpt4v_instruct_gpt4-vision_cap100k_COCO_only.json --num-prompts 10 --port 8001 --save-result --result-dir ~/vllm_benchmark_results --save-detailed --endpoint /v1/chat/completion

Sample config:

[
    {
        "id": "000000000009",
        "image": "/home/huachenheli/datasets/COCO/train2017/000000000009.jpg",
        "conversations": [
            {
                "from": "human",
                "value": "What do you see happening in this image?\n<image>"
            },
            {
                "from": "gpt",
                "value": "In the center of the image, a vibrant blue lunch tray holds four containers, each brimming with a variety of food items. The containers, two in pink and two in yellow, are arranged in a 2x2 grid.\n\nIn the top left pink container, a slice of bread rests, lightly spread with butter and sprinkled with a handful of almonds. The bread is cut into a rectangle, and the almonds are scattered across its buttery surface.\n\nAdjacent to it in the top right corner, another pink container houses a mix of fruit. Sliced apples with their fresh white interiors exposed share the space with juicy chunks of pineapple. The colors of the apple slices and pineapple chunks contrast beautifully against the pink container.\n\nBelow these, in the bottom left corner of the tray, a yellow container holds a single meatball alongside some broccoli. The meatball, round and browned, sits next to the vibrant green broccoli florets.\n\nFinally, in the bottom right yellow container, there's a sweet treat - a chocolate chip cookie. The golden-brown cookie is dotted with chocolate chips, their dark color standing out against the cookie's lighter surface.\n\nThe arrangement of these containers on the blue tray creates a visually appealing and balanced meal, with each component neatly separated yet part of a cohesive whole."
            }
        ]
    },
    ...
]

Reviewers:

@DarkLight1337 @ywang96 @Isotr0py

Subscribers:

Tasks:

Tags:

Purpose

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the performance Performance-related issues label Aug 15, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for image data in the ShareGPTDataset for benchmarking. The changes are straightforward and align with the PR's goal. I've identified one potential issue related to handling null or empty image paths in the dataset, which could cause the benchmark to crash. I've included a suggestion to make the image processing more robust.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
@huachenheli huachenheli marked this pull request as ready for review August 15, 2025 03:28
@DarkLight1337 DarkLight1337 requested a review from ywang96 August 15, 2025 03:29
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks reasonable to me but I'll have @ywang96 take a look as well

Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look reasonable too. Just a nit.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! On a side note, we should probably start removing things from benchmarks folder to reduce confusion 😅

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 15, 2025 08:43
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 15, 2025
@huachenheli
Copy link
Contributor Author

LGTM! On a side note, we should probably start removing things from benchmarks folder to reduce confusion 😅

SG. I was about to ask why we have two LOL

@DarkLight1337 DarkLight1337 merged commit 993d3d1 into vllm-project:main Aug 15, 2025
39 checks passed
666even666 pushed a commit to 666even666/vllm that referenced this pull request Aug 18, 2025
…m-project#22955)

Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Signed-off-by: Yiwen Chen <yiwen66@berkeley.edu>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
…m-project#22955)

Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…m-project#22955)

Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
sducouedic pushed a commit to sducouedic/vllm that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants