- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.9k
[Benchmarks] Include image data when ShareGPT4V dataset is used. #22955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
| 👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run  Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add  🚀 | 
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds support for image data in the ShareGPTDataset for benchmarking. The changes are straightforward and align with the PR's goal. I've identified one potential issue related to handling null or empty image paths in the dataset, which could cause the benchmark to crash. I've included a suggestion to make the image processing more robust.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks reasonable to me but I'll have @ywang96 take a look as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look reasonable too. Just a nit.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! On a side note, we should probably start removing things from benchmarks folder to reduce confusion 😅
| 
 SG. I was about to ask why we have two LOL | 
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com> Signed-off-by: Yiwen Chen <yiwen66@berkeley.edu>
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
…m-project#22955) Signed-off-by: Chenheli Hua <huachenheli@outlook.com>
Summary:
Currently when ShareGPT4V dataset is used, the image data is not passed to the vLLM server correctly. This PR fixes the issue.
Test Plan:
vLLM:
Request sender:
Sample config:
Reviewers:
@DarkLight1337 @ywang96 @Isotr0py
Subscribers:
Tasks:
Tags:
Purpose
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.