-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[CI] Remove duplicated docs build from buildkite #22924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmellor
commented
Aug 14, 2025
- This job provides no additional signal that the Read the Docs build does not
- Removing it will save a small amount of money by reducing the time spent on CPU machines in buildkite CI
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a duplicated documentation build step from the Buildkite CI pipeline to reduce CI costs. The changes are logical and consistent across the pipeline configuration, Dockerfile, and a test script. My review includes one suggestion for the Dockerfile to further optimize the CI process by consolidating RUN commands, which aligns with the PR's goal of improving efficiency.
| RUN mkdir src | ||
| RUN mv vllm src/vllm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To optimize the Docker image and align with best practices, it's recommended to chain related shell commands into a single RUN instruction. Each RUN command creates a new layer in the Docker image. Reducing the number of layers can lead to smaller image sizes and potentially faster build times, which is consistent with the goal of this PR to reduce CI costs. Using mv vllm src/ is also more idiomatic for moving a directory into another.
RUN mkdir src && mv vllm src/
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>