Skip to content

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Aug 14, 2025

  • This job provides no additional signal that the Read the Docs build does not
  • Removing it will save a small amount of money by reducing the time spent on CPU machines in buildkite CI

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Aug 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a duplicated documentation build step from the Buildkite CI pipeline to reduce CI costs. The changes are logical and consistent across the pipeline configuration, Dockerfile, and a test script. My review includes one suggestion for the Dockerfile to further optimize the CI process by consolidating RUN commands, which aligns with the PR's goal of improving efficiency.

Comment on lines +503 to +504
RUN mkdir src
RUN mv vllm src/vllm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To optimize the Docker image and align with best practices, it's recommended to chain related shell commands into a single RUN instruction. Each RUN command creates a new layer in the Docker image. Reducing the number of layers can lead to smaller image sizes and potentially faster build times, which is consistent with the goal of this PR to reduce CI costs. Using mv vllm src/ is also more idiomatic for moving a directory into another.

RUN mkdir src && mv vllm src/

@hmellor hmellor enabled auto-merge (squash) August 14, 2025 18:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 14, 2025
@vllm-bot vllm-bot merged commit e8b40c7 into vllm-project:main Aug 15, 2025
70 of 72 checks passed
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor deleted the rm-buildkite-doc-test branch September 29, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants