-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Frontend] Expose do_log_stats interval to env #22905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Csrayz <jover@cmbchina.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable feature by exposing the do_log_stats interval as an environment variable, which is very useful for debugging. The implementation is straightforward and the documentation update is helpful. I have one suggestion to improve the code quality in vllm/envs.py by refactoring the environment variable parsing logic to be more efficient and maintainable.
Signed-off-by: Csrayz <jover@cmbchina.com>
Signed-off-by: Csrayz <jover@cmbchina.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Csrayz <jover@cmbchina.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Csrayz <jover@cmbchina.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
Signed-off-by: Csrayz <jover@cmbchina.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Csrayz <jover@cmbchina.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
Signed-off-by: Csrayz <jover@cmbchina.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Purpose
Sometimes, to track the changes in the waiting and running queues over time for specific load scenarios, it is necessary to reduce the time interval of calling do_log_stats in api_server. This is because excessively long time intervals can lead to unobservable metric changes during the interval.
For example, in scenarios with very long inputs but short outputs, the running queue may always appear as 1. However, theoretically, the running queue should show 2/3/... in some cases. This happens when a single request's size is much larger than the token budget. After the previous request's prefill is completed, it will still be in the running queue for decoding, and the next request will also be placed in the running queue for processing. At this point, it should be possible to see the running queue change from 1 to 2. However, due to the long interval between two do_log_stats calls, the decoding request has already finished, making it impossible to observe this phenomenon.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.