- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.9k
[Log] Debug Once for Randomizing dummy data for DP Rank #22860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Log] Debug Once for Randomizing dummy data for DP Rank #22860
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
| 👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run  Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add  🚀 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates a logging call from logger.debug to logger.debug_once. This is a good change that prevents the log message about randomizing dummy data for DP Rank from being printed repeatedly, which improves log clarity. The change is correct and I found no issues of high or critical severity.
…#22860) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Yiwen Chen <yiwen66@berkeley.edu>
…#22860) Signed-off-by: yewentao256 <zhyanwentao@126.com>
…#22860) Signed-off-by: yewentao256 <zhyanwentao@126.com>
…#22860) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
…#22860) Signed-off-by: yewentao256 <zhyanwentao@126.com>
…#22860) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…#22860) Signed-off-by: yewentao256 <zhyanwentao@126.com>
Purpose
Debug Once for Randomizing dummy data for DP Rank