-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Misc] Ignore ep_kernels_workspace #22807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the ep_kernels_workspace directory to .gitignore to prevent build artifacts from being committed. This is a good change. However, the current gitignore pattern is too specific and will fail if the installation script is run from the repository's root directory. I've provided a suggestion to make the pattern more robust to handle this scenario.
.gitignore
Outdated
| csrc/moe/marlin_moe_wna16/kernel_* | ||
|
|
||
| # Ignore ep_kernels_workspace folder | ||
| tools/ep_kernels/ep_kernels_workspace/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The install_python_libraries.sh script creates the ep_kernels_workspace in the current working directory (pwd). If the script is run from the repository root, the workspace will be created at the root, and this .gitignore entry will not match. To ensure the workspace is ignored regardless of where the script is executed, it's better to use a more general pattern that matches the directory name anywhere in the repository.
ep_kernels_workspace/
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is also an eep workspace
| WORKSPACE=$(pwd)/eep_kernels_workspace |
Could we also have the scripts cleanup once installed, or do they need to stay around?
It looks like they need to be kept. |
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update