Skip to content

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Aug 13, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the ep_kernels_workspace directory to .gitignore to prevent build artifacts from being committed. This is a good change. However, the current gitignore pattern is too specific and will fail if the installation script is run from the repository's root directory. I've provided a suggestion to make the pattern more robust to handle this scenario.

.gitignore Outdated
csrc/moe/marlin_moe_wna16/kernel_*

# Ignore ep_kernels_workspace folder
tools/ep_kernels/ep_kernels_workspace/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The install_python_libraries.sh script creates the ep_kernels_workspace in the current working directory (pwd). If the script is run from the repository root, the workspace will be created at the root, and this .gitignore entry will not match. To ensure the workspace is ignored regardless of where the script is executed, it's better to use a more general pattern that matches the directory name anywhere in the repository.

ep_kernels_workspace/

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is also an eep workspace

WORKSPACE=$(pwd)/eep_kernels_workspace

Could we also have the scripts cleanup once installed, or do they need to stay around?

@jeejeelee
Copy link
Collaborator Author

Looks like there is also an eep workspace

WORKSPACE=$(pwd)/eep_kernels_workspace

Could we also have the scripts cleanup once installed, or do they need to stay around?

It looks like they need to be kept.

deep_ep                           1.1.0+d9767ce        /Code/vllm/tools/ep_kernels/ep_kernels_workspace/DeepEP

@jeejeelee jeejeelee requested a review from mgoin August 14, 2025 01:11
@vllm-bot vllm-bot merged commit 48f4636 into vllm-project:main Aug 15, 2025
12 of 14 checks passed
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants