- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.9k
[CI] run tests/compile/test_config.py #22682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Richard Zou <zou3519@gmail.com>
| 👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run  Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add  🚀 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds a missing test, tests/compile/test_config.py, to the CI pipeline. My review focuses on improving the maintainability of this CI step. I've suggested replacing the explicit list of test files with a single command to run all tests in the directory. This will prevent similar omissions in the future and make the CI configuration more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this as-is and we can organize better later
…estcases. Signed-off-by: Luka Govedic <lgovedic@redhat.com>
Run compile config tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
| This pull request has merge conflicts that must be resolved before it can be | 
Signed-off-by: Luka Govedič <ProExpertProg@users.noreply.github.com>
| This failed again due to  | 
| Yea not sure why it fails here but not on main or locally... Perhaps we just update the tolerance. Also the rmsnorm fusion test succeeds locally for me | 
| I don't believe adjusting the tolerance is a good idea. While it might hide the numerical issues in the short term, it's not a sustainable solution as it avoids addressing the root cause. | 
| @ZJY0516 these tolerances are pretty arbitrary, we don't have a good reason for it to be what it currently is. That's why we rely on E2E lm_eval testing | 
Purpose
This test wasn't being run in CI
Test Plan
Run test locally.
Wait for CI, read logs
Test Result
Test passed locally