-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[V1][Hybrid][Backend] Allow different data types in Hybrid Cache Manager #22544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[V1][Hybrid][Backend] Allow different data types in Hybrid Cache Manager #22544
Conversation
Signed-off-by: Burkhard Ringlein <ngl@zurich.ibm.com>
Signed-off-by: Burkhard Ringlein <ngl@zurich.ibm.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces functionality to allow different data types for attention and mamba layers in hybrid models, which is a valuable optimization. However, the current implementation has a few critical issues that need to be addressed. The new configuration options, cache_dtype_attention
and cache_dtype_mamba
, are used in compute_hash
but are commented out in the CacheConfig
definition, which will cause an AttributeError
. Additionally, there's a NameError
in FlashAttentionImpl
due to an undefined variable. Finally, a new and seemingly redundant environment variable is introduced in gpu_model_runner.py
, creating a confusing configuration path. Addressing these issues will make the feature robust and maintainable.
Signed-off-by: Burkhard Ringlein <ngl@zurich.ibm.com>
Signed-off-by: Burkhard Ringlein <ngl@zurich.ibm.com>
This pull request has merge conflicts that must be resolved before it can be |
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Depends on #21549
Test Plan
Test Result
(Optional) Documentation Update