Skip to content

Conversation

@shen-shanshan
Copy link
Contributor

@shen-shanshan shen-shanshan commented Aug 8, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Currently, the default length of the output in structured output example is short and the result can be incomplete.

Guided decoding by Choice: Positive
Guided decoding by Regex: alan_turing@enigma.com
# Incomplete outputs:
Guided decoding by JSON: {"brand": "Porsche", "model": "911", "
Guided decoding by Grammar: SELECT col_1  from table_1  where col

Add max_tokens to sampling_params to make the output more complete:

# ...
Guided decoding by JSON: {"brand": "Porsche", "model": "911", "car_type": "sedan"}
Guided decoding by Grammar: SELECT col_1  from table_1  where col_2 = 1

Test Plan

Test Result

(Optional) Documentation Update

@mergify mergify bot added documentation Improvements or additions to documentation structured-output labels Aug 8, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where the structured output example could produce incomplete results. By introducing a MAX_TOKENS constant and applying it to the sampling parameters for regex, JSON, and grammar-guided decoding, the change ensures that the generated outputs are complete. The implementation is clean and effectively solves the problem described. The code looks good, and I have no further comments.

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@shen-shanshan shen-shanshan changed the title [Structured Output][Example] Make The Output of Structured Output Example More Complete [Structured Output] Make The Output of Structured Output Example More Complete Aug 8, 2025
@shen-shanshan shen-shanshan changed the title [Structured Output] Make The Output of Structured Output Example More Complete [Structured Output] Make the output of structured output example more complete Aug 8, 2025
Signed-off-by: shen-shanshan <467638484@qq.com>
@russellb russellb enabled auto-merge (squash) August 15, 2025 16:53
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 15, 2025
@russellb russellb merged commit 48b01fd into vllm-project:main Aug 15, 2025
24 of 26 checks passed
666even666 pushed a commit to 666even666/vllm that referenced this pull request Aug 18, 2025
… complete (vllm-project#22481)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Yiwen Chen <yiwen66@berkeley.edu>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
… complete (vllm-project#22481)

Signed-off-by: shen-shanshan <467638484@qq.com>
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
… complete (vllm-project#22481)

Signed-off-by: shen-shanshan <467638484@qq.com>
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
… complete (vllm-project#22481)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
… complete (vllm-project#22481)

Signed-off-by: shen-shanshan <467638484@qq.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
… complete (vllm-project#22481)

Signed-off-by: shen-shanshan <467638484@qq.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
… complete (vllm-project#22481)

Signed-off-by: shen-shanshan <467638484@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants