-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Move flashinfer-python to optional extra vllm[flashinfer]
#21959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move flashinfer-python to optional extra vllm[flashinfer]
#21959
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to make flashinfer-python an optional dependency by moving it to an extra vllm[flashinfer]. The changes in requirements/cuda.txt and setup.py correctly reflect this. However, there's a significant inconsistency with the Dockerfile, which still installs flashinfer from source unconditionally. This should be addressed to ensure the dependency is truly optional for all users, including those using the official Docker images.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…ject#21959) Signed-off-by: mgoin <mgoin64@gmail.com>
…ject#21959) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Jinzhen Lin <linjinzhen@hotmail.com>
…ject#21959) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Noam Gat <noamgat@gmail.com>
…ject#21959) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Paul Pak <paulpak58@gmail.com>
…ject#21959) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Diego-Castan <diego.castan@ibm.com>
…ject#21959) Signed-off-by: mgoin <mgoin64@gmail.com>
…ject#21959) Signed-off-by: mgoin <mgoin64@gmail.com>
Adding flashinfer-python by default to the CUDA requirements introduced a new hard requirement for vLLM to have
nvccinstalled, which we don't want to enforce for all users. See issue #21960For now we will move the dependency as an extras i.e.
uv pip install vllm[flashinfer]